Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1214513003: Remove references into sky/engine/core/fetch (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove references into sky/engine/core/fetch This CL removes all references to sky/engine/core/fetch from outside that directory. All these references appear to be dead code. Also, remove a few "loader" classes that were also dead code. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9271e144f77782576d06ab1b3415bf82663e08fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1199 lines) Patch
M sky/engine/core/core.gni View 2 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/core/css/CSSGradientValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSImageGeneratorValue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSImageGeneratorValue.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M sky/engine/core/css/FontFaceCache.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 4 chunks +0 lines, -12 lines 0 comments Download
D sky/engine/core/css/resolver/StyleResourceLoader.h View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/engine/core/css/resolver/StyleResourceLoader.cpp View 1 chunk +0 lines, -86 lines 0 comments Download
M sky/engine/core/dom/DOMURL.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Document.h View 4 chunks +1 line, -5 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 6 chunks +0 lines, -15 lines 0 comments Download
M sky/engine/core/editing/Editor.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/fetch/ResourceFetcher.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/fetch/ResourceFetcher.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/LocalFrame.h View 4 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/frame/LocalFrame.cpp View 4 chunks +0 lines, -8 lines 0 comments Download
D sky/engine/core/loader/FrameFetchContext.h View 1 chunk +0 lines, -74 lines 0 comments Download
D sky/engine/core/loader/FrameFetchContext.cpp View 1 chunk +0 lines, -110 lines 0 comments Download
M sky/engine/core/loader/FrameLoader.h View 3 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/loader/FrameLoader.cpp View 4 chunks +0 lines, -7 lines 0 comments Download
D sky/engine/core/loader/ImageLoader.h View 1 chunk +0 lines, -157 lines 0 comments Download
D sky/engine/core/loader/ImageLoader.cpp View 1 chunk +0 lines, -464 lines 0 comments Download
D sky/engine/core/loader/MojoLoader.h View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/engine/core/loader/MojoLoader.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
M sky/engine/core/page/Page.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/engine/platform/fetcher/MojoFetcher.h View 1 chunk +0 lines, -39 lines 0 comments Download
D sky/engine/platform/fetcher/MojoFetcher.cpp View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-06 00:16:07 UTC) #1
abarth-chromium
5 years, 5 months ago (2015-07-06 03:03:51 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9271e144f77782576d06ab1b3415bf82663e08fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698