Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ppc/full-codegen-ppc.cc

Issue 1214483008: Fix clobbered register when setting this_function variable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed think'o. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips64/full-codegen-mips64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_PPC 7 #if V8_TARGET_ARCH_PPC
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 } 241 }
242 } 242 }
243 } 243 }
244 } 244 }
245 245
246 // Possibly set up a local binding to the this function which is used in 246 // Possibly set up a local binding to the this function which is used in
247 // derived constructors with super calls. 247 // derived constructors with super calls.
248 Variable* this_function_var = scope()->this_function_var(); 248 Variable* this_function_var = scope()->this_function_var();
249 if (this_function_var != nullptr) { 249 if (this_function_var != nullptr) {
250 Comment cmnt(masm_, "[ This function"); 250 Comment cmnt(masm_, "[ This function");
251 if (!function_in_register) {
252 __ LoadP(r4, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
253 // The write barrier clobbers register again, keep is marked as such.
254 }
251 SetVar(this_function_var, r4, r3, r5); 255 SetVar(this_function_var, r4, r3, r5);
252 } 256 }
253 257
254 Variable* new_target_var = scope()->new_target_var(); 258 Variable* new_target_var = scope()->new_target_var();
255 if (new_target_var != nullptr) { 259 if (new_target_var != nullptr) {
256 Comment cmnt(masm_, "[ new.target"); 260 Comment cmnt(masm_, "[ new.target");
257 261
258 // Get the frame pointer for the calling frame. 262 // Get the frame pointer for the calling frame.
259 __ LoadP(r5, MemOperand(fp, StandardFrameConstants::kCallerFPOffset)); 263 __ LoadP(r5, MemOperand(fp, StandardFrameConstants::kCallerFPOffset));
260 264
(...skipping 5315 matching lines...) Expand 10 before | Expand all | Expand 10 after
5576 return ON_STACK_REPLACEMENT; 5580 return ON_STACK_REPLACEMENT;
5577 } 5581 }
5578 5582
5579 DCHECK(interrupt_address == 5583 DCHECK(interrupt_address ==
5580 isolate->builtins()->OsrAfterStackCheck()->entry()); 5584 isolate->builtins()->OsrAfterStackCheck()->entry());
5581 return OSR_AFTER_STACK_CHECK; 5585 return OSR_AFTER_STACK_CHECK;
5582 } 5586 }
5583 } // namespace internal 5587 } // namespace internal
5584 } // namespace v8 5588 } // namespace v8
5585 #endif // V8_TARGET_ARCH_PPC 5589 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « src/mips64/full-codegen-mips64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698