Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 1214483008: Fix clobbered register when setting this_function variable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed think'o. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 } 245 }
246 } 246 }
247 } 247 }
248 } 248 }
249 249
250 // Possibly set up a local binding to the this function which is used in 250 // Possibly set up a local binding to the this function which is used in
251 // derived constructors with super calls. 251 // derived constructors with super calls.
252 Variable* this_function_var = scope()->this_function_var(); 252 Variable* this_function_var = scope()->this_function_var();
253 if (this_function_var != nullptr) { 253 if (this_function_var != nullptr) {
254 Comment cmnt(masm_, "[ This function"); 254 Comment cmnt(masm_, "[ This function");
255 if (!function_in_register) {
256 __ lw(a1, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
257 // The write barrier clobbers register again, keep is marked as such.
258 }
255 SetVar(this_function_var, a1, a2, a3); 259 SetVar(this_function_var, a1, a2, a3);
256 } 260 }
257 261
258 Variable* new_target_var = scope()->new_target_var(); 262 Variable* new_target_var = scope()->new_target_var();
259 if (new_target_var != nullptr) { 263 if (new_target_var != nullptr) {
260 Comment cmnt(masm_, "[ new.target"); 264 Comment cmnt(masm_, "[ new.target");
261 265
262 // Get the frame pointer for the calling frame. 266 // Get the frame pointer for the calling frame.
263 __ lw(a2, MemOperand(fp, StandardFrameConstants::kCallerFPOffset)); 267 __ lw(a2, MemOperand(fp, StandardFrameConstants::kCallerFPOffset));
264 268
(...skipping 5308 matching lines...) Expand 10 before | Expand all | Expand 10 after
5573 reinterpret_cast<uint32_t>( 5577 reinterpret_cast<uint32_t>(
5574 isolate->builtins()->OsrAfterStackCheck()->entry())); 5578 isolate->builtins()->OsrAfterStackCheck()->entry()));
5575 return OSR_AFTER_STACK_CHECK; 5579 return OSR_AFTER_STACK_CHECK;
5576 } 5580 }
5577 5581
5578 5582
5579 } // namespace internal 5583 } // namespace internal
5580 } // namespace v8 5584 } // namespace v8
5581 5585
5582 #endif // V8_TARGET_ARCH_MIPS 5586 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698