Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: src/arm64/full-codegen-arm64.cc

Issue 1214483008: Fix clobbered register when setting this_function variable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed think'o. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 } 237 }
238 } 238 }
239 } 239 }
240 } 240 }
241 241
242 // Possibly set up a local binding to the this function which is used in 242 // Possibly set up a local binding to the this function which is used in
243 // derived constructors with super calls. 243 // derived constructors with super calls.
244 Variable* this_function_var = scope()->this_function_var(); 244 Variable* this_function_var = scope()->this_function_var();
245 if (this_function_var != nullptr) { 245 if (this_function_var != nullptr) {
246 Comment cmnt(masm_, "[ This function"); 246 Comment cmnt(masm_, "[ This function");
247 if (!function_in_register_x1) {
248 __ Ldr(x1, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
249 // The write barrier clobbers register again, keep is marked as such.
250 }
247 SetVar(this_function_var, x1, x0, x2); 251 SetVar(this_function_var, x1, x0, x2);
248 } 252 }
249 253
250 Variable* new_target_var = scope()->new_target_var(); 254 Variable* new_target_var = scope()->new_target_var();
251 if (new_target_var != nullptr) { 255 if (new_target_var != nullptr) {
252 Comment cmnt(masm_, "[ new.target"); 256 Comment cmnt(masm_, "[ new.target");
253 // Get the frame pointer for the calling frame. 257 // Get the frame pointer for the calling frame.
254 __ Ldr(x2, MemOperand(fp, StandardFrameConstants::kCallerFPOffset)); 258 __ Ldr(x2, MemOperand(fp, StandardFrameConstants::kCallerFPOffset));
255 259
256 Label check_frame_marker; 260 Label check_frame_marker;
(...skipping 5340 matching lines...) Expand 10 before | Expand all | Expand 10 after
5597 } 5601 }
5598 5602
5599 return INTERRUPT; 5603 return INTERRUPT;
5600 } 5604 }
5601 5605
5602 5606
5603 } // namespace internal 5607 } // namespace internal
5604 } // namespace v8 5608 } // namespace v8
5605 5609
5606 #endif // V8_TARGET_ARCH_ARM64 5610 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698