Issue 1214483007: Fix blur bug on Andreno 430 with bool cast to float

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1214483007: Fix blur bug on Andreno 430 with bool cast to float (Closed)

Created:
5 years, 5 months ago by bsalomon

Modified:
5 years, 5 months ago

Reviewers:
joshualitt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	src/gpu/effects/GrConvolutionEffect.cpp	View		1 chunk	+10 lines, -3 lines	0 comments	Download

Total messages: 6 (2 generated)

bsalomon

According to my new benchmark, this has no impact on perf.

5 years, 5 months ago (2015-06-30 15:47:35 UTC) #2

joshualitt

On 2015/06/30 15:47:35, bsalomon wrote: > According to my new benchmark, this has no impact ...

5 years, 5 months ago (2015-06-30 15:48:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214483007/20001

5 years, 5 months ago (2015-06-30 16:12:20 UTC) #5

commit-bot: I haz the power

5 years, 5 months ago (2015-06-30 16:19:17 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ffe6ebb8a8fd93091e2f5ca3fc9d8cd21b9c92df