Improve the ProfileInfoCache API.

chrome/browser/profiles/profile_attributes_storage.h

Index: chrome/browser/profiles/profile_attributes_storage.h
diff --git a/chrome/browser/profiles/profile_attributes_storage.h b/chrome/browser/profiles/profile_attributes_storage.h
new file mode 100644
index 0000000000000000000000000000000000000000..38277f09ad8757512938440c5443ab48b04a7019
--- /dev/null
+++ b/chrome/browser/profiles/profile_attributes_storage.h
@@ -0,0 +1,46 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PROFILES_PROFILE_ATTRIBUTES_STORAGE_H_
+#define CHROME_BROWSER_PROFILES_PROFILE_ATTRIBUTES_STORAGE_H_
+
+class ProfileAttributesEntry;
+
+class ProfileAttributesStorage {
+ public:
+  ProfileAttributesStorage() {}
+  ~ProfileAttributesStorage() {}
+
+  // If the |supervised_user_id| is non-empty, the profile will be marked to be
+  // omitted from the avatar-menu list on desktop versions. This is used while a
+  // supervised user is in the process of being registered with the server. Use
+  // ProfileAttributesEntry::SetIsOmitted() to clear the flag when the profile
+  // is ready to be shown in the menu.
+  virtual void AddProfile(const base::FilePath& profile_path,
+                          const base::string16& name,
+                          const std::string& gaia_id,
+                          const base::string16& user_name,
+                          size_t icon_index,
+                          const std::string& supervised_user_id) = 0;
+  virtual void DeleteProfile(const base::FilePath& profile_path) = 0;

[Mike Lerman, 2015/07/08 18:26:35]

Please add a comment for this method. e.g. it doesn't delete profile data from
disk, merely boots the associated profile out of this Storage.

[anthonyvd, 2015/07/09 17:02:13]

Added the comment and renamed the method to RemoveProfile() since that probably
reflects the actual operation and aligns with AddProfile better.

+
+  // Returns a vector containing one attributes entry per known profile. They
+  // are not sorted in any particular order.
+  virtual std::vector<ProfileAttributesEntry*> GetAllProfilesAttributes() = 0;
+
+  // Populates |entry| with the data for the profile at |path| and returns true
+  // if the operation is successful and |entry| can be used. Returns false
+  // otherwise.
+  // |entry| should not be cached as it will not reflect subsequent changes to

[Mike Lerman, 2015/07/08 18:26:35]

s/will/may. It actually DOES reflect subsequent changes in the current
implementation.

[anthonyvd, 2015/07/09 17:02:13]

Good point, done.

+  // the profile's metadata.
+  virtual bool GetProfileAttributesWithPath(
+      const base::FilePath& path, ProfileAttributesEntry** entry) = 0;
+
+  // Returns the count of known profiles.
+  virtual size_t GetNumberOfProfiles() const = 0;
+
+  DISALLOW_COPY_AND_ASSIGN(ProfileAttributesStorage);
+};
+
+#endif  // CHROME_BROWSER_PROFILES_PROFILE_ATTRIBUTES_STORAGE_H_