Improve the ProfileInfoCache API.

chrome/browser/profiles/profile_attributes_storage.h

Index: chrome/browser/profiles/profile_attributes_storage.h
diff --git a/chrome/browser/profiles/profile_attributes_storage.h b/chrome/browser/profiles/profile_attributes_storage.h
new file mode 100644
index 0000000000000000000000000000000000000000..a6bbcc4ff2ed368819790fcce75e101b27ba253e
--- /dev/null
+++ b/chrome/browser/profiles/profile_attributes_storage.h
@@ -0,0 +1,46 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PROFILES_PROFILE_ATTRIBUTES_STORAGE_H_
+#define CHROME_BROWSER_PROFILES_PROFILE_ATTRIBUTES_STORAGE_H_
+
+#include "chrome/browser/profiles/profile_attributes_entry.h"
+
+class ProfileAttributesStorage {
+ public:
+  ProfileAttributesStorage() {}
+  ~ProfileAttributesStorage() {}
+
+  // If the |supervised_user_id| is non-empty, the profile will be marked to be
+  // omitted from the avatar-menu list on desktop versions. This is used while a
+  // supervised user is in the process of being registered with the server. Use
+  // ProfileAttributesEntry::SetIsOmitted() to clear the flag when the profile
+  // is ready to be shown in the menu.
+  virtual void AddProfile(const base::FilePath& profile_path,
+                          const base::string16& name,
+                          const std::string& gaia_id,
+                          const base::string16& user_name,
+                          size_t icon_index,
+                          const std::string& supervised_user_id) = 0;
+  virtual void DeleteProfile(const base::FilePath& profile_path) = 0;
+
+  // Returns a vector containing one attributes entry per known profile. They
+  // are not sorted in any particular order.
+  virtual std::vector<ProfileAttributesEntry> GetAllProfilesAttributes() = 0;

[Mike Lerman, 2015/07/02 18:01:30]

As in the other comment - if it's not sorted, perhaps use std::set instead of
std::vector

[anthonyvd, 2015/07/07 21:05:32]

Replied to the other comment :)

+
+  // Populates |entry| with the data for the profile at |path| and returns true
+  // if the operation is successful and |entry| can be used. Returns false
+  // otherwise.
+  // |entry| should not be cached as it will not reflect subsequent changes to
+  // the profile's metadata.
+  virtual bool GetProfileAttributesWithPath(
+      const base::FilePath& path, ProfileAttributesEntry* entry) = 0;
+
+  // Returns the count of known profiles.
+  virtual size_t GetNumberOfProfiles() const = 0;
+
+  DISALLOW_COPY_AND_ASSIGN(ProfileAttributesStorage);
+};
+
+#endif  // CHROME_BROWSER_PROFILES_PROFILE_ATTRIBUTES_STORAGE_H_