Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: chrome/browser/profiles/profile_info_cache.h

Issue 1214483002: Improve the ProfileInfoCache API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_info_cache.h
diff --git a/chrome/browser/profiles/profile_info_cache.h b/chrome/browser/profiles/profile_info_cache.h
index 38edaa2ca68faa0e8d9eed414d9d59073d84d743..75370a3d0756a56a3e7a32b8c13abb3ee4fb8bd5 100644
--- a/chrome/browser/profiles/profile_info_cache.h
+++ b/chrome/browser/profiles/profile_info_cache.h
@@ -17,6 +17,7 @@
#include "base/strings/string16.h"
#include "chrome/browser/profiles/profile_info_cache_observer.h"
#include "chrome/browser/profiles/profile_info_interface.h"
+#include "chrome/browser/profiles/profile_metadata_storage.h"
namespace gfx {
class Image;
@@ -34,6 +35,7 @@ class ProfileAvatarDownloader;
// This cache can be used to display a list of profiles without having to
// actually load the profiles from disk.
class ProfileInfoCache : public ProfileInfoInterface,
+ public ProfileMetadataStorage,
public base::SupportsWeakPtr<ProfileInfoCache> {
public:
ProfileInfoCache(PrefService* prefs, const base::FilePath& user_data_dir);
@@ -161,6 +163,20 @@ class ProfileInfoCache : public ProfileInfoInterface,
disable_avatar_download_for_testing_ = disable_avatar_download_for_testing;
}
+ // ProfileMetadataStorage implementation
Mike Lerman 2015/06/29 19:14:37 nit: I think the style standard is // ProfileMetad
anthonyvd 2015/06/30 21:24:52 Done.
+ void AddProfile(const base::FilePath& profile_path,
+ const base::string16& name,
+ const std::string& gaia_id,
+ const base::string16& user_name,
+ size_t icon_index,
+ const std::string& supervised_user_id) override;
+ void DeleteProfile(const base::FilePath& profile_path) override;
+ std::vector<ProfileMetadataStorage::ProfileMetadataEntry>
+ GetAllProfilesMetadata() override;
Mike Lerman 2015/06/29 19:14:37 nit: indent 4 spaces please.
anthonyvd 2015/06/30 21:24:52 Done.
+ bool GetProfileMetadataWithPath(
+ const base::FilePath& path,
+ ProfileMetadataStorage::ProfileMetadataEntry* entry) override;
+
private:
FRIEND_TEST_ALL_PREFIXES(ProfileInfoCacheTest, DownloadHighResAvatarTest);
FRIEND_TEST_ALL_PREFIXES(ProfileInfoCacheTest,
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_info_cache.cc » ('j') | chrome/browser/profiles/profile_info_cache.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698