Improve the ProfileInfoCache API.

chrome/browser/profiles/profile_info_cache.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_info_cache.h"
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/i18n/case_conversion.h"
 #include "base/logging.h"
@@ skipping 241 matching lines @@
 
   FOR_EACH_OBSERVER(ProfileInfoCacheObserver,
                     observer_list_,
                     OnProfileWillBeRemoved(profile_path));
 
   DictionaryPrefUpdate update(prefs_, prefs::kProfileInfoCache);
   base::DictionaryValue* cache = update.Get();
   std::string key = CacheKeyFromProfilePath(profile_path);
   cache->Remove(key, NULL);
   sorted_keys_.erase(std::find(sorted_keys_.begin(), sorted_keys_.end(), key));
+  profile_attributes_entries_.erase(profile_path);
 
   FOR_EACH_OBSERVER(ProfileInfoCacheObserver,
                     observer_list_,
                     OnProfileWasRemoved(profile_path, name));
 }
 
 size_t ProfileInfoCache::GetNumberOfProfiles() const {
   return sorted_keys_.size();
 }
 
@@ skipping 959 matching lines @@
   std::vector<base::FilePath>::const_iterator it;
   for (it = profiles_to_rename.begin(); it != profiles_to_rename.end(); ++it) {
     size_t profile_index = GetIndexOfProfileWithPath(*it);
     SetProfileIsUsingDefaultNameAtIndex(profile_index, true);
     // This will assign a new "Person %d" type name and re-sort the cache.
     SetNameOfProfileAtIndex(profile_index, ChooseNameForNewProfile(
         GetAvatarIconIndexOfProfileAtIndex(profile_index)));
   }
 #endif
 }
+
+void ProfileInfoCache::AddProfile(
+    const base::FilePath& profile_path,
+    const base::string16& name,
+    const std::string& gaia_id,
+    const base::string16& user_name,
+    size_t icon_index,
+    const std::string& supervised_user_id) {
+  AddProfileToCache(
+      profile_path, name, gaia_id, user_name, icon_index, supervised_user_id);
+}
+
+void ProfileInfoCache::DeleteProfile(const base::FilePath& profile_path) {
+  DeleteProfileFromCache(profile_path);
+}
+
+std::vector<ProfileAttributesEntry*>
+ProfileInfoCache::GetAllProfilesAttributes() {
+  std::vector<ProfileAttributesEntry*> ret;
+  for (size_t i = 0; i < GetNumberOfProfiles(); ++i) {
+    ProfileAttributesEntry* entry;
+    if (GetProfileAttributesWithPath(GetPathOfProfileAtIndex(i), &entry)) {
+      ret.push_back(entry);
+    }
+  }
+  return ret;
+}
+
+bool ProfileInfoCache::GetProfileAttributesWithPath(
+    const base::FilePath& path, ProfileAttributesEntry** entry) {
+  if (GetNumberOfProfiles() == 0) {

[Mike Lerman, 2015/07/08 18:26:35]

nit: braces unneeded here - the condition's really short.
(and just below)

[anthonyvd, 2015/07/09 17:02:14]

Done.

+    return false;
+  }
+
+  size_t index = GetIndexOfProfileWithPath(path);

[Mike Lerman, 2015/07/08 18:26:35]

inline GetIndexOfProfileWithPath into the condition below; we don't use index
anywhere else anymore.

[anthonyvd, 2015/07/09 17:02:14]

Done.

+  if (index == std::string::npos) {
+    return false;
+  }
+
+  if (profile_attributes_entries_.find(path) ==
+      profile_attributes_entries_.end()) {
+    // The profile info is in the cache but its entry isn't created yet, insert
+    // it in the map.
+    profile_attributes_entries_[path].Initialize(this, path);
+  }
+
+  *entry = &profile_attributes_entries_[path];
+  return true;
+}