Source/modules/webaudio/ConvolverNode.cpp - Issue 1214463003: Split "Online" and "Offline" AudioContext processing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/ConvolverNode.cpp

Issue 1214463003: Split "Online" and "Offline" AudioContext processing (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/webaudio/AudioContext.cpp ('k') | Source/modules/webaudio/OfflineAudioContext.h » ('j') | Source/modules/webaudio/OnlineAudioContext.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/ConvolverNode.cpp

diff --git a/Source/modules/webaudio/ConvolverNode.cpp b/Source/modules/webaudio/ConvolverNode.cpp

index eb5188bc3a54d4f7fd0313d465c0cd4a2b2f8a79..d68da4228dfa262f675962480ba8c384d9ed66f7 100644

--- a/Source/modules/webaudio/ConvolverNode.cpp

+++ b/Source/modules/webaudio/ConvolverNode.cpp

@@ -127,8 +127,7 @@ void ConvolverHandler::setBuffer(AudioBuffer* buffer, ExceptionState& exceptionS

bufferBus->setSampleRate(buffer->sampleRate());

// Create the reverb with the given impulse response.

- bool useBackgroundThreads = !context()->isOfflineContext();

- OwnPtr<Reverb> reverb = adoptPtr(new Reverb(bufferBus.get(), ProcessingSizeInFrames, MaxFFTSize, 2, useBackgroundThreads, m_normalize));

+ OwnPtr<Reverb> reverb = adoptPtr(new Reverb(bufferBus.get(), ProcessingSizeInFrames, MaxFFTSize, 2, context() && context()->hasRealtimeConstraint(), m_normalize));

{

// Synchronize with process().

« no previous file with comments | « Source/modules/webaudio/AudioContext.cpp ('k') | Source/modules/webaudio/OfflineAudioContext.h » ('j') | Source/modules/webaudio/OnlineAudioContext.h » ('J')