Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 1214433006: Add .sdkext file to make Dart analyzer understand dart:sky (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add .sdkext file to make Dart analyzer understand dart:sky This file will be used by a future version of the Dart analyzer to understand Dart code that uses the dart:sky package. R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/be96a984524a8c58e01440d05d14927c05fc0392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M sky/sdk/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A sky/sdk/lib/.sdkext View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-07 20:46:10 UTC) #1
Cutch
lgtm
5 years, 5 months ago (2015-07-07 20:46:31 UTC) #2
abarth-chromium
5 years, 5 months ago (2015-07-07 20:46:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
be96a984524a8c58e01440d05d14927c05fc0392 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698