Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1214363002: Remove default for --images in common flags (Closed)

Created:
5 years, 5 months ago by bsalomon
Modified:
5 years, 5 months ago
Reviewers:
msarett, scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove default for --images in common flags Committed: https://skia.googlesource.com/skia/+/73bb435a5896d47f633f5e58e299b88d086c71c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/flags/SkCommonFlags.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
bsalomon
5 years, 5 months ago (2015-06-30 15:40:04 UTC) #2
scroggo
Matt, it looks like you made resources/ the default image directory for nanobench (in addition ...
5 years, 5 months ago (2015-06-30 15:43:51 UTC) #4
msarett
lgtm Yes! Looks good. It's my understanding that the bots use the gsutil images, so ...
5 years, 5 months ago (2015-06-30 16:25:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214363002/1
5 years, 5 months ago (2015-06-30 16:27:56 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 16:38:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/73bb435a5896d47f633f5e58e299b88d086c71c0

Powered by Google App Engine
This is Rietveld 408576698