Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1214333002: Disable zapping of code space. (Closed)

Created:
5 years, 5 months ago by Hannes Payer (out of office)
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable zapping of code space. BUG= Committed: https://crrev.com/8fdcd13b5248161a40bda8663828791c1c902b06 Cr-Commit-Position: refs/heads/master@{#29386}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Michael Starzinger
LGTM. It's but a five character change, nothing can go wrong.
5 years, 5 months ago (2015-06-30 15:05:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214333002/1
5 years, 5 months ago (2015-06-30 15:05:34 UTC) #4
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1214333002/diff/1/src/flag-definitions.h File src/flag-definitions.h (left): https://codereview.chromium.org/1214333002/diff/1/src/flag-definitions.h#oldcode688 src/flag-definitions.h:688: DEFINE_BOOL(zap_code_space, true, can you make the default depend on ...
5 years, 5 months ago (2015-06-30 15:15:09 UTC) #6
Hannes Payer (out of office)
https://codereview.chromium.org/1214333002/diff/1/src/flag-definitions.h File src/flag-definitions.h (left): https://codereview.chromium.org/1214333002/diff/1/src/flag-definitions.h#oldcode688 src/flag-definitions.h:688: DEFINE_BOOL(zap_code_space, true, On 2015/06/30 15:15:09, jochen wrote: > can ...
5 years, 5 months ago (2015-06-30 15:49:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214333002/20001
5 years, 5 months ago (2015-06-30 15:56:54 UTC) #11
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-06-30 16:08:56 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-06-30 16:29:03 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 16:29:14 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8fdcd13b5248161a40bda8663828791c1c902b06
Cr-Commit-Position: refs/heads/master@{#29386}

Powered by Google App Engine
This is Rietveld 408576698