Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4431)

Unified Diff: chrome/common/localized_error.cc

Issue 1214303003: Add UMA histograms for Google cached copy experiment on network error interstitial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/localized_error.cc
diff --git a/chrome/common/localized_error.cc b/chrome/common/localized_error.cc
index 568b7806a0b89b4cd0ec4f29cfe9e093e5a68a18..0568bf40a8c0c2a93437adf2de51c210a07e4bb7 100644
--- a/chrome/common/localized_error.cc
+++ b/chrome/common/localized_error.cc
@@ -897,16 +897,17 @@ void LocalizedError::EnableGoogleCachedCopyButtonExperiment(
suggestion->GetInteger("trackingId", &cache_tracking_id);
scoped_ptr<base::DictionaryValue> cache_button(new base::DictionaryValue);
-
if (field_trial_exp_type_ == kCachedCopyButtonExpTypeCopy) {
cache_button->SetString(
"msg",
l10n_util::GetStringUTF16(IDS_ERRORPAGES_BUTTON_SHOW_CACHED_COPY));
+ cache_button->SetBoolean("defaultLabel", false);
} else {
// Default to "Show cached page" button label.
cache_button->SetString(
"msg",
l10n_util::GetStringUTF16(IDS_ERRORPAGES_BUTTON_SHOW_CACHED_PAGE));
+ cache_button->SetBoolean("defaultLabel", true);
}
cache_button->SetString("cacheUrl", cache_url);
cache_button->SetInteger("trackingId", cache_tracking_id);
« no previous file with comments | « no previous file | chrome/renderer/net/net_error_helper.h » ('j') | components/error_page/common/net_error_info.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698