chrome/renderer/net/net_error_helper.h - Issue 1214303003: Add UMA histograms for Google cached copy experiment on network error interstitial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/net/net_error_helper.h

Issue 1214303003: Add UMA histograms for Google cached copy experiment on network error interstitial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix NetErrorHelperCore unittest Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/net/net_error_helper.h

diff --git a/chrome/renderer/net/net_error_helper.h b/chrome/renderer/net/net_error_helper.h

index 53caef9b520b9465d00f7b1420d1f40c52264ba2..b9da4fe2e18799414f04caa1a19e4ab706294ef6 100644

--- a/chrome/renderer/net/net_error_helper.h

+++ b/chrome/renderer/net/net_error_helper.h

@@ -89,6 +89,8 @@ class NetErrorHelper

scoped_ptr<error_page::ErrorPageParams> params,

bool* reload_button_shown,

bool* show_saved_copy_button_shown,

+ bool* show_cached_copy_button_shown,

+ bool* show_cached_page_button_shown,

std::string* html) const override;

void LoadErrorPageInMainFrame(const std::string& html,

const GURL& failed_url) override;

« no previous file with comments | « chrome/common/localized_error.cc ('k') | chrome/renderer/net/net_error_helper.cc » ('j') | no next file with comments »