Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 1214293002: Get rid of findPlainText() with Range parameter (Closed)

Created:
5 years, 5 months ago by yosin_UTC9
Modified:
5 years, 5 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Get rid of findPlainText() with Range parameter This patch removes |findPlainText()| with |Range| parameter by replacing call sites with |findPlainText()| with two |Position| parameters to avoid constructing redundant |Range| object for Oilpan GC friendly. BUGS=n/a TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198041

Patch Set 1 #

Patch Set 2 : 2015-06-30T15:11:38 Get rid of unused function collapsedToBoundary() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -29 lines) Patch
M Source/core/editing/iterators/CharacterIterator.cpp View 1 2 chunks +0 lines, -27 lines 0 comments Download
M Source/core/editing/iterators/TextIterator.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/iterators/TextIteratorTest.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 5 months ago (2015-06-30 05:46:48 UTC) #2
yoichio
lgtm
5 years, 5 months ago (2015-06-30 07:55:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214293002/20001
5 years, 5 months ago (2015-06-30 08:48:43 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 08:52:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198041

Powered by Google App Engine
This is Rietveld 408576698