Issue 1214263002: Fix corrupted rendering of images

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1214263002: Fix corrupted rendering of images (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
jackson

CC:
mojo-reviews_chromium.org, jackson_old, gregsimon, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix corrupted rendering of images When navigating from one app to another, we create a new Android window and destroy the old one. Previously, when we destroyed the old window after creating the new window, we would destroy the Ganesh context after making the GL context for the new window current, causing us to corrupt the GL state in the new window. After this CL, we call MakeCurrent before destroying the Ganesh context so that it interacts with the proper GL context. R=jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c35e3edfd2ead620d21800a15eb0952ef72cb26b

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	sky/shell/gpu/ganesh_context.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	sky/shell/gpu/rasterizer.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-06-29 23:40:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c35e3edfd2ead620d21800a15eb0952ef72cb26b (presubmit successful).

Expand Messages | Collapse Messages