Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1214213002: Add get_skp_repos endpoint to skia-telemetry (Closed)

Created:
5 years, 5 months ago by borenet
Modified:
5 years, 5 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add get_skp_repos endpoint to skia-telemetry BUG=skia:3979 Committed: https://skia.googlesource.com/buildbot/+/d2146f6ebeb33b5e9f908c2c6f8fa06f7f6b24df

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use defaultdict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M appengine_scripts/skia-tree-status/main.py View 1 chunk +1 line, -0 lines 0 comments Download
M appengine_scripts/skia-tree-status/skia_telemetry.py View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
borenet
5 years, 5 months ago (2015-06-29 17:49:34 UTC) #2
rmistry
lgtm https://codereview.chromium.org/1214213002/diff/1/appengine_scripts/skia-tree-status/skia_telemetry.py File appengine_scripts/skia-tree-status/skia_telemetry.py (right): https://codereview.chromium.org/1214213002/diff/1/appengine_scripts/skia-tree-status/skia_telemetry.py#newcode643 appengine_scripts/skia-tree-status/skia_telemetry.py:643: rv = {} rv = collections.defaultdict(list) then line ...
5 years, 5 months ago (2015-06-29 18:33:55 UTC) #3
borenet
https://codereview.chromium.org/1214213002/diff/1/appengine_scripts/skia-tree-status/skia_telemetry.py File appengine_scripts/skia-tree-status/skia_telemetry.py (right): https://codereview.chromium.org/1214213002/diff/1/appengine_scripts/skia-tree-status/skia_telemetry.py#newcode643 appengine_scripts/skia-tree-status/skia_telemetry.py:643: rv = {} On 2015/06/29 at 18:33:55, rmistry wrote: ...
5 years, 5 months ago (2015-06-29 18:50:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214213002/20001
5 years, 5 months ago (2015-06-29 18:51:42 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 18:52:29 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/d2146f6ebeb33b5e9f908c2c6f8fa06f7f6b...

Powered by Google App Engine
This is Rietveld 408576698