Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5907)

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.cc

Issue 1214183008: Update StartsWith calls to use new versions in chrome and content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/service/cloud_print/cloud_print_connector.cc ('k') | chrome/test/chromedriver/performance_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/web_view_impl.cc
diff --git a/chrome/test/chromedriver/chrome/web_view_impl.cc b/chrome/test/chromedriver/chrome/web_view_impl.cc
index c1ec10e403bd0c550e619e5f10f3ecfbe906d618..c87f1393d3f4bc81684453e9af0fca5557ad2acd 100644
--- a/chrome/test/chromedriver/chrome/web_view_impl.cc
+++ b/chrome/test/chromedriver/chrome/web_view_impl.cc
@@ -155,7 +155,8 @@ Status WebViewImpl::HandleReceivedEvents() {
Status WebViewImpl::Load(const std::string& url) {
// Javascript URLs will cause a hang while waiting for the page to stop
// loading, so just disallow.
- if (base::StartsWithASCII(url, "javascript:", false))
+ if (base::StartsWith(url, "javascript:",
+ base::CompareCase::INSENSITIVE_ASCII))
return Status(kUnknownError, "unsupported protocol");
base::DictionaryValue params;
params.SetString("url", url);
« no previous file with comments | « chrome/service/cloud_print/cloud_print_connector.cc ('k') | chrome/test/chromedriver/performance_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698