chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc - Issue 1214183008: Update StartsWith calls to use new versions in chrome and content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

Issue 1214183008: Update StartsWith calls to use new versions in chrome and content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

diff --git a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

index c2a4e7be6a4648a003edb504fc7d617fab40f7bb..9ec60f06023f004ed383f529143f3f7ee5f830a3 100644

--- a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

+++ b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

@@ -200,8 +200,8 @@ FileBrowserHandler* LoadFileBrowserHandler(

return NULL;

}

base::StringToLowerASCII(&filter);

- if (!base::StartsWithASCII(

- filter, std::string(url::kFileSystemScheme) + ':', true)) {

+ if (!base::StartsWith(filter, std::string(url::kFileSystemScheme) + ':',

+ base::CompareCase::SENSITIVE)) {

*error = extensions::ErrorUtils::FormatErrorMessageUTF16(

errors::kInvalidURLPatternError, filter);

return NULL;

« no previous file with comments | « chrome/common/crash_keys.cc ('k') | chrome/common/extensions/chrome_extensions_client.cc » ('j') | no next file with comments »