chrome/browser/chromeos/input_method/input_method_engine.cc - Issue 1214183008: Update StartsWith calls to use new versions in chrome and content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine.cc

Issue 1214183008: Update StartsWith calls to use new versions in chrome and content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_manager/file_tasks.cc ('k') | chrome/browser/chromeos/input_method/input_method_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_engine.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_engine.cc b/chrome/browser/chromeos/input_method/input_method_engine.cc

index 6bb4f86ec0edcaabbbffeb808cee2d6b8325ed03..8b73134c79af3102c12b1754c3617a14b5bd74f2 100644

--- a/chrome/browser/chromeos/input_method/input_method_engine.cc

+++ b/chrome/browser/chromeos/input_method/input_method_engine.cc

@@ -72,13 +72,13 @@ size_t GetUtf8StringLength(const char* s) {

std::string GetKeyFromEvent(const ui::KeyEvent& event) {

const std::string code = event.GetCodeString();

- if (base::StartsWithASCII(code, "Control", true))

+ if (base::StartsWith(code, "Control", base::CompareCase::SENSITIVE))

return "Ctrl";

- if (base::StartsWithASCII(code, "Shift", true))

+ if (base::StartsWith(code, "Shift", base::CompareCase::SENSITIVE))

return "Shift";

- if (base::StartsWithASCII(code, "Alt", true))

+ if (base::StartsWith(code, "Alt", base::CompareCase::SENSITIVE))

return "Alt";

- if (base::StartsWithASCII(code, "Arrow", true))

+ if (base::StartsWith(code, "Arrow", base::CompareCase::SENSITIVE))

return code.substr(5);

if (code == "Escape")

return "Esc";