Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: sky/sdk/example/stocks/lib/stock_settings.dart

Issue 1214113006: Add a new item to the settings page to show off the switch widget. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/example/stocks/lib/main.dart ('k') | sky/sdk/example/stocks/lib/stock_types.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/example/stocks/lib/stock_settings.dart
diff --git a/sky/sdk/example/stocks/lib/stock_settings.dart b/sky/sdk/example/stocks/lib/stock_settings.dart
index 97f417a55201c7cbbd80957e1f3475c67dcf717b..04be1ac325498bd078b1a660c7c38e377323130d 100644
--- a/sky/sdk/example/stocks/lib/stock_settings.dart
+++ b/sky/sdk/example/stocks/lib/stock_settings.dart
@@ -5,6 +5,7 @@
import 'package:sky/theme/colors.dart' as colors;
import 'package:sky/widgets/basic.dart';
import 'package:sky/widgets/checkbox.dart';
+import 'package:sky/widgets/switch.dart';
import 'package:sky/widgets/flat_button.dart';
import 'package:sky/widgets/dialog.dart';
import 'package:sky/widgets/icon_button.dart';
@@ -15,34 +16,47 @@ import 'package:sky/widgets/tool_bar.dart';
import 'stock_types.dart';
-typedef void SettingsUpdater({StockMode mode});
+typedef void SettingsUpdater({
+ StockMode optimism,
+ BackupMode backup
+});
class StockSettings extends Component {
- StockSettings(this.navigator, this.stockMode, this.updater) : super(stateful: true);
+ StockSettings(this.navigator, this.optimism, this.backup, this.updater) : super(stateful: true);
Navigator navigator;
- StockMode stockMode;
+ StockMode optimism;
+ BackupMode backup;
SettingsUpdater updater;
+
bool showModeDialog = false;
void syncFields(StockSettings source) {
navigator = source.navigator;
- stockMode = source.stockMode;
+ optimism = source.optimism;
+ backup = source.backup;
updater = source.updater;
}
- void _handleStockModeChanged(bool value) {
+ void _handleOptimismChanged(bool value) {
+ setState(() {
+ optimism = value ? StockMode.optimistic : StockMode.pessimistic;
+ });
+ sendUpdates();
+ }
+
+ void _handleBackupChanged(bool value) {
setState(() {
- stockMode = value ? StockMode.optimistic : StockMode.pessimistic;
+ backup = value ? BackupMode.enabled : BackupMode.disabled;
});
sendUpdates();
}
- void _confirmStockModeChange() {
- switch (stockMode) {
+ void _confirmOptimismChange() {
+ switch (optimism) {
case StockMode.optimistic:
- _handleStockModeChanged(false);
+ _handleOptimismChanged(false);
break;
case StockMode.pessimistic:
showModeDialog = true;
@@ -56,7 +70,8 @@ class StockSettings extends Component {
void sendUpdates() {
if (updater != null)
updater(
- mode: stockMode
+ optimism: optimism,
+ backup: backup
);
}
@@ -70,16 +85,26 @@ class StockSettings extends Component {
}
Widget buildSettingsPane() {
+ // TODO(ianh): Once we have the gesture API hooked up, fix https://github.com/domokit/mojo/issues/281
+ // (whereby tapping the widgets below causes both the widget and the menu item to fire their callbacks)
return new Container(
padding: const EdgeDims.symmetric(vertical: 20.0),
decoration: new BoxDecoration(backgroundColor: colors.Grey[50]),
child: new Block([
new MenuItem(
icon: 'action/thumb_up',
- onPressed: () => _confirmStockModeChange(),
+ onPressed: () => _confirmOptimismChange(),
children: [
new Flexible(child: new Text('Everything is awesome')),
- new Checkbox(value: stockMode == StockMode.optimistic, onChanged: _handleStockModeChanged)
+ new Checkbox(value: optimism == StockMode.optimistic, onChanged: _handleOptimismChanged)
+ ]
+ ),
+ new MenuItem(
+ icon: 'action/backup',
+ onPressed: () { _handleBackupChanged(!(backup == BackupMode.enabled)); },
+ children: [
+ new Flexible(child: new Text('Back up stock list to the cloud')),
+ new Switch(value: backup == BackupMode.enabled, onChanged: _handleBackupChanged)
]
),
])
@@ -87,10 +112,12 @@ class StockSettings extends Component {
}
Widget build() {
- List<Widget> layers = [new Scaffold(
+ List<Widget> layers = [
+ new Scaffold(
toolbar: buildToolBar(),
body: buildSettingsPane()
- )];
+ )
+ ];
if (showModeDialog) {
layers.add(new Dialog(
title: new Text("Change mode?"),
@@ -104,7 +131,7 @@ class StockSettings extends Component {
new FlatButton(
child: new Text('AGREE'),
onPressed: () {
- _handleStockModeChanged(true);
+ _handleOptimismChanged(true);
navigator.pop();
}
),
« no previous file with comments | « sky/sdk/example/stocks/lib/main.dart ('k') | sky/sdk/example/stocks/lib/stock_types.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698