Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1214113005: Rebase test expectations that print bound function names (Closed)

Created:
5 years, 5 months ago by arv (Not doing code reviews)
Modified:
5 years, 5 months ago
Reviewers:
adamk
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rebase test expectations that print bound function names BUG=chromium:502437 R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/inspector-protocol/runtime/runtime-getProperties-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/editor/text-editor-indent-autodetection-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/properties-special-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 5 months ago (2015-06-29 21:36:17 UTC) #1
adamk
lgtm Sad those tests are so stupid. Makes me wish there was someone focusing on ...
5 years, 5 months ago (2015-06-29 21:41:25 UTC) #2
arv (Not doing code reviews)
On 2015/06/29 21:41:25, adamk wrote: > Maybe everyone should just write W3C test harness tests. ...
5 years, 5 months ago (2015-06-29 21:56:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214113005/1
5 years, 5 months ago (2015-06-29 21:56:39 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 00:38:15 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198028

Powered by Google App Engine
This is Rietveld 408576698