Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1808)

Unified Diff: appengine_scripts/skia-tree-status/skia_telemetry.py

Issue 1214113004: Make the CT Lua script endpoint decode base64 (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine_scripts/skia-tree-status/skia_telemetry.py
diff --git a/appengine_scripts/skia-tree-status/skia_telemetry.py b/appengine_scripts/skia-tree-status/skia_telemetry.py
index 75a61c7669634675b0353662c6e55f9da1950046..7787037679bdf873d54d7cc895da3cd4ddc881ce 100644
--- a/appengine_scripts/skia-tree-status/skia_telemetry.py
+++ b/appengine_scripts/skia-tree-status/skia_telemetry.py
@@ -5,6 +5,7 @@
"""Skia Telemetry pages."""
+import base64
import datetime
import json
import urllib2
@@ -564,10 +565,10 @@ class AdminTasksPage(BasePage):
self.DisplayTemplate('admin_tasks.html', template_values)
-def _AddLuaTask(request, username):
+def _AddLuaTask(request, username, lua_script, lua_aggregator):
requested_time = datetime.datetime.now()
- lua_script = db.Text(request.get('lua_script'))
- lua_aggregator = db.Text(request.get('lua_aggregator'))
+ lua_script = db.Text(lua_script)
+ lua_aggregator = db.Text(lua_aggregator)
description = request.get('description')
pagesets_type, chromium_rev, skia_rev = request.get(
'pagesets_type_and_chromium_build').split('-')
@@ -589,7 +590,12 @@ class AddLuaTask(BasePage):
"""Adds the specified lua task."""
@utils.admin_only
def post(self):
- _AddLuaTask(self.request, self.request.get('username'))
+ username = self.request.get('username')
+ lua_script = urllib2.unquote(base64.b64decode(
+ self.request.get('lua_script')))
+ lua_aggregator = urllib2.unquote(base64.b64decode(
+ self.request.get('lua_aggregator')))
+ _AddLuaTask(self.request, username, lua_script, lua_aggregator)
class LuaScriptPage(BasePage):
@@ -609,7 +615,9 @@ class LuaScriptPage(BasePage):
return
# It is an add lua task request.
- _AddLuaTask(self.request, self.user.email())
+ lua_script = self.request.get('lua_script')
+ lua_aggregator = self.request.get('lua_aggregator')
+ _AddLuaTask(self.request, self.user.email(), lua_script, lua_aggregator)
self.redirect('lua_script')
def _handle(self):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698