Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1214083002: Use non-zero values when testing neutral keyframe correctness (Closed)

Created:
5 years, 5 months ago by alancutter (OOO until 2018)
Modified:
5 years, 5 months ago
Reviewers:
dstockwell, shans
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use non-zero values when testing neutral keyframe correctness Neutral keyframes represent the underlying CSS value. This can be implemented internally by adding zero to the underlying value. This test should avoid using zero for an underlying value to ensure the "add zero" neutral keyframe implementation is not accidentally replacing with zero. BUG=437696 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197960

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M LayoutTests/animations/responsive/left-responsive.html View 2 chunks +14 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
alancutter (OOO until 2018)
5 years, 5 months ago (2015-06-29 01:33:52 UTC) #2
shans
lgtm
5 years, 5 months ago (2015-06-29 02:29:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214083002/1
5 years, 5 months ago (2015-06-29 04:06:41 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 05:26:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197960

Powered by Google App Engine
This is Rietveld 408576698