Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1214073014: Back button should kill interactive flex app (Closed)

Created:
5 years, 5 months ago by jackson
Modified:
5 years, 5 months ago
Reviewers:
abarth, abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : abarth cr feedback #

Patch Set 3 : rebase and add missing file #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M sky/sdk/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/rendering/interactive_flex.dart View 1 2 chunks +4 lines, -0 lines 0 comments Download
A sky/sdk/lib/mojo/activity.dart View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/widget.dart View 1 2 chunks +2 lines, -5 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
https://codereview.chromium.org/1214073014/diff/1/sky/sdk/example/rendering/interactive_flex.dart File sky/sdk/example/rendering/interactive_flex.dart (right): https://codereview.chromium.org/1214073014/diff/1/sky/sdk/example/rendering/interactive_flex.dart#newcode54 sky/sdk/example/rendering/interactive_flex.dart:54: } Should we factor this into a library since ...
5 years, 5 months ago (2015-07-07 18:10:26 UTC) #2
jackson
https://codereview.chromium.org/1214073014/diff/1/sky/sdk/example/rendering/interactive_flex.dart File sky/sdk/example/rendering/interactive_flex.dart (right): https://codereview.chromium.org/1214073014/diff/1/sky/sdk/example/rendering/interactive_flex.dart#newcode54 sky/sdk/example/rendering/interactive_flex.dart:54: } On 2015/07/07 18:10:26, abarth-chromium wrote: > Should we ...
5 years, 5 months ago (2015-07-07 19:17:30 UTC) #3
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-07 19:22:18 UTC) #4
abarth-chromium
https://codereview.chromium.org/1214073014/diff/40001/sky/sdk/lib/widgets/widget.dart File sky/sdk/lib/widgets/widget.dart (right): https://codereview.chromium.org/1214073014/diff/40001/sky/sdk/lib/widgets/widget.dart#newcode10 sky/sdk/lib/widgets/widget.dart:10: import 'package:sky/mojo/activity.dart' as activity; We should make these imports ...
5 years, 5 months ago (2015-07-07 19:22:49 UTC) #5
jackson
5 years, 5 months ago (2015-07-07 19:57:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
ffa919ef3c54f0583ef769abda8ed8f7d6efa283 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698