Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 1214063008: Reduce resolution of performance.now to prevent timing attacks (Closed)

Created:
5 years, 5 months ago by Kunihiko Sakamoto
Modified:
5 years, 5 months ago
Reviewers:
Mark Seaborn, pdr., inferno
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reduce resolution of performance.now to prevent timing attacks This is a backport of the following WebKit patches by Alex Christensen <achristensen@apple.com>;: http://trac.webkit.org/changeset/186208 http://trac.webkit.org/changeset/186219 BUG=506723 TEST=http/tests/misc/webtiming-resolution.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
A LayoutTests/http/tests/misc/webtiming-resolution.html View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/misc/webtiming-resolution-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/timing/PerformanceBase.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Kunihiko Sakamoto
5 years, 5 months ago (2015-07-06 05:55:15 UTC) #2
pdr.
This is correct but I'd prefer if someone from the security team could give this ...
5 years, 5 months ago (2015-07-06 22:18:47 UTC) #4
inferno
On 2015/07/06 22:18:47, pdr wrote: > This is correct but I'd prefer if someone from ...
5 years, 5 months ago (2015-07-06 22:32:33 UTC) #6
pdr.
LGTM for owner approval.
5 years, 5 months ago (2015-07-06 22:55:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214063008/1
5 years, 5 months ago (2015-07-06 22:55:43 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 23:47:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198348

Powered by Google App Engine
This is Rietveld 408576698