Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1214063007: Revert of Convert compositor_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by tapted
Modified:
5 years, 5 months ago
Reviewers:
danakj, Nico, M-A Ruel
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert compositor_unittests to run exclusively on Swarming (patchset #6 id:100001 of https://codereview.chromium.org/1211053005/) Reason for revert: Causing steps exception compositor_unittests on Linux ChromiumOS Tests (dbg)(1) Link: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/4229 Shard https://chromium-swarm.appspot.com/user/task/286f8616fee52710 says Outputs: Output: Sending the crash report ... done. Report URL: https://isolateserver.appspot.com/restricted/ereporter2/errors/5669961011822592 IsolatedFile a8902feeee5e075f3f92ec6ae3299106595667a3 is retrieved recursively Original issue's description: > Convert compositor_unittests to run exclusively on Swarming > > 0 configs already ran on Swarming > 18 used to run locally and were converted: > - chromium.chromiumos.json: Linux ChromiumOS Tests (1) > - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) > - chromium.fyi.json: ClangToTLinux tester > - chromium.fyi.json: Linux Trusty > - chromium.fyi.json: Linux Trusty (dbg) > - chromium.linux.json: Linux Tests > - chromium.linux.json: Linux Tests (dbg)(1) > - chromium.linux.json: Linux Tests (dbg)(1)(32) > - chromium.memory.fyi.json: Linux ChromeOS MSan Tests > - chromium.memory.fyi.json: Linux MSan Tests > - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) > - chromium.webkit.json: Linux ChromiumOS Tests (1) > - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) > - chromium.win.json: Vista Tests (1) > - chromium.win.json: Win 7 Tests x64 (1) > - chromium.win.json: Win7 Tests (1) > - chromium.win.json: Win7 Tests (dbg)(1) > - chromium.win.json: XP Tests (1) > > Ran: > ./manage.py --convert compositor_unittests > > BUG=98637 > > Committed: https://crrev.com/db1d33845c8847693ab97db88fbcff754c6b3a5b > Cr-Commit-Position: refs/heads/master@{#337334} TBR=danakj@chromium.org,maruel@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Committed: https://crrev.com/d903850ee3b13ee59aadea96cea7e52f0d4bd8c4 Cr-Commit-Position: refs/heads/master@{#337352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -129 lines) Patch
M build/gn_migration.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 2 chunks +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 3 chunks +0 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 3 chunks +0 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 chunk +0 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 2 chunks +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +0 lines, -15 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +0 lines, -15 lines 0 comments Download
D ui/compositor/compositor_unittests.isolate View 1 chunk +0 lines, -59 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tapted
Created Revert of Convert compositor_unittests to run exclusively on Swarming
5 years, 5 months ago (2015-07-05 23:32:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214063007/1
5 years, 5 months ago (2015-07-05 23:32:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-05 23:32:30 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-05 23:33:24 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d903850ee3b13ee59aadea96cea7e52f0d4bd8c4
Cr-Commit-Position: refs/heads/master@{#337352}

Powered by Google App Engine
This is Rietveld 408576698