Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1214023003: Revert of Switch SkJpegCode to libjpeg-turbo (Closed)

Created:
5 years, 5 months ago by msarett
Modified:
5 years, 5 months ago
Reviewers:
scroggo, emmaleer, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Switch SkJpegCode to libjpeg-turbo (patchset #25 id:680001 of https://codereview.chromium.org/1180983002/) Reason for revert: yasm is leaking memory :(. https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/926/steps/build%20dm/logs/stdio Original issue's description: > Add libjpeg-turbo library (depends on yasm) > Mangle external function names to avoid conflict with libjpeg > Take advantage of direct color conversion (RGBA, BGRA, 565) > Prepare to use jpeg_skip_scanlines (when it is upstreamed) > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/b60c3f8291529303299262dba19b1a896060bd2d > > Committed: https://skia.googlesource.com/skia/+/f8bf9181d7b0463c8e371755cfbb9ece90b34fc5 TBR=scroggo@google.com,djsollen@google.com,emmaleer@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/f657b1093ef22390d3ce1eb56686a8185408a84f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -29362 lines) Patch
M DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M dm/DM.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/codec.gyp View 2 chunks +1 line, -17 lines 0 comments Download
D gyp/libjpeg-turbo.gyp View 1 chunk +0 lines, -340 lines 0 comments Download
D gyp/yasm.gyp View 1 chunk +0 lines, -644 lines 0 comments Download
M src/codec/SkCodec.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M src/codec/SkJpegCodec.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 12 chunks +170 lines, -152 lines 0 comments Download
M src/codec/SkJpegDecoderMgr.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/codec/SkJpegDecoderMgr.cpp View 2 chunks +14 lines, -1 line 0 comments Download
M src/codec/SkJpegUtility_codec.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/codec/SkJpegUtility_codec.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/yasm/README.skia View 1 chunk +0 lines, -138 lines 0 comments Download
D third_party/yasm/config/android/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/android/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/config/android/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/chromeos/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/chromeos/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/config/chromeos/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/ios/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/ios/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/config/ios/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/linux/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/linux/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/config/linux/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/mac/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/mac/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/config/mac/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/openbsd/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/openbsd/config.h View 1 chunk +0 lines, -165 lines 0 comments Download
D third_party/yasm/config/openbsd/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/win/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/win/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/config/win/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/win/stdint.h View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
msarett
Created Revert of Switch SkJpegCode to libjpeg-turbo
5 years, 5 months ago (2015-06-29 17:30:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214023003/1
5 years, 5 months ago (2015-06-29 17:30:45 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 17:31:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f657b1093ef22390d3ce1eb56686a8185408a84f

Powered by Google App Engine
This is Rietveld 408576698