bench/subset/SubsetSingleBench.cpp - Issue 1213983003: Fix CodecSubset benches seg faults for kIndex8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bench/subset/SubsetSingleBench.cpp

Issue 1213983003: Fix CodecSubset benches seg faults for kIndex8 (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: bench/subset/SubsetSingleBench.cpp

diff --git a/bench/subset/SubsetSingleBench.cpp b/bench/subset/SubsetSingleBench.cpp

index 68c94cd246b125a27ba26e6bec7a2f6409006bb4..b2fc68fd4f1f3ddd68f020474c2ddfe2dc61b1c9 100644

--- a/bench/subset/SubsetSingleBench.cpp

+++ b/bench/subset/SubsetSingleBench.cpp

@@ -70,7 +70,8 @@ void SubsetSingleBench::onDraw(const int n, SkCanvas* canvas) {

info, NULL, colors, &colorCount);

SkBitmap bitmap;

- bitmap.allocPixels(info.makeWH(fSubsetWidth, fSubsetHeight));

+ SkImageInfo subsetInfo = info.makeWH(fSubsetWidth, fSubsetHeight);

+ alloc_pixels(&bitmap, subsetInfo, fColorType, colors, colorCount);

scanlineDecoder->skipScanlines(fOffsetTop);

uint32_t bpp = info.bytesPerPixel();