Isolate extensions_unittests.

Isolate extensions_unittests.

BUG=98637
Committed: https://crrev.com/298db6077696167ea79fd2786498431330d9abd1
Cr-Commit-Position: refs/heads/master@{#336928}

[M-A Ruel, 2015-06-29 17:53:12]

maruel@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2015-06-29 17:53:12]

https://codereview.chromium.org/1213943002/diff/20001/extensions/extensions_u...
File extensions/extensions_unittests.isolate (left):

https://codereview.chromium.org/1213943002/diff/20001/extensions/extensions_u...
extensions/extensions_unittests.isolate:33: '<(PRODUCT_DIR)/xdisplaycheck',
You need it. It's used by xvfb.py.

[Reilly Grant (use Gerrit), 2015-06-29 18:47:42]

https://codereview.chromium.org/1213943002/diff/20001/extensions/extensions_u...
File extensions/extensions_unittests.isolate (left):

https://codereview.chromium.org/1213943002/diff/20001/extensions/extensions_u...
extensions/extensions_unittests.isolate:33: '<(PRODUCT_DIR)/xdisplaycheck',
On 2015/06/29 17:53:12, M-A Ruel wrote:
> You need it. It's used by xvfb.py.

I moved it up here but that didn't seem to resolve the "UNKNOWN" test failures.

[M-A Ruel, 2015-06-29 18:53:29]

On 2015/06/29 18:47:42, reillyg wrote:
>
https://codereview.chromium.org/1213943002/diff/20001/extensions/extensions_u...
> File extensions/extensions_unittests.isolate (left):
> 
>
https://codereview.chromium.org/1213943002/diff/20001/extensions/extensions_u...
> extensions/extensions_unittests.isolate:33: '<(PRODUCT_DIR)/xdisplaycheck',
> On 2015/06/29 17:53:12, M-A Ruel wrote:
> > You need it. It's used by xvfb.py.
> 
> I moved it up here but that didn't seem to resolve the "UNKNOWN" test
failures.

You need test data files. From grepping around for a mnute, I found that this
seems to be necessary:
extensions/extensions_resources.grd:11:      <include
name="IDR_EXTENSION_API_FEATURES" file="common\api\_api_features.json"
type="BINDATA" />

[M-A Ruel, 2015-06-29 18:53:40]

https://codereview.chromium.org/1213943002/diff/40001/extensions/extensions_u...
File extensions/extensions_unittests.isolate (right):

https://codereview.chromium.org/1213943002/diff/40001/extensions/extensions_u...
extensions/extensions_unittests.isolate:43: 'read_only': 1,
Not needed, it's the default.

[Reilly Grant (use Gerrit), 2015-06-29 23:09:23]

Patchset #1 (id:1) has been deleted

[Reilly Grant (use Gerrit), 2015-06-29 23:09:32]

Patchset #3 (id:60001) has been deleted

[Reilly Grant (use Gerrit), 2015-06-29 23:09:41]

Patchset #3 (id:80001) has been deleted

[Reilly Grant (use Gerrit), 2015-06-30 19:48:14]

Patchset #3 (id:100001) has been deleted

[Reilly Grant (use Gerrit), 2015-06-30 19:48:27]

Patchset #3 (id:100001) has been deleted

[Reilly Grant (use Gerrit), 2015-06-30 22:04:37]

Patchset #3 (id:120001) has been deleted

[Reilly Grant (use Gerrit), 2015-06-30 22:28:40]

Please take a look.

[Marc-Antoine Ruel (Google), 2015-06-30 23:05:01]

maruel@google.com changed reviewers:
+ maruel@google.com

[Marc-Antoine Ruel (Google), 2015-06-30 23:05:02]

lgtm

[Reilly Grant (use Gerrit), 2015-06-30 23:06:34]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2015-06-30 23:07:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1213943002/140001

[commit-bot: I haz the power, 2015-06-30 23:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-30 23:18:27]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[M-A Ruel, 2015-06-30 23:19:50]

On 2015/06/30 23:18:27, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

lgtm

[M-A Ruel, 2015-06-30 23:20:09]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2015-06-30 23:21:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1213943002/140001

[commit-bot: I haz the power, 2015-07-01 00:10:54]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2015-07-01 00:11:51]

Patchset 3 (id:??) landed as
https://crrev.com/298db6077696167ea79fd2786498431330d9abd1
Cr-Commit-Position: refs/heads/master@{#336928}