Issue 1213873002: Use Theme to define the colors and TextStyles for Tab, TabBar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1213873002: Use Theme to define the colors and TextStyles for Tab, TabBar (Closed)

Created:
5 years, 5 months ago by hansmuller1

Modified:
5 years, 5 months ago

Reviewers:
hansmuller, Hixie, abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Use Theme to define the colors and TextStyles for Tab, TabBar Also added a smoke test for examples/widgets/tabs.dart. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a3dc3d45cc29ce7b1b529a1267d901201db55f07

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+180 lines, -21 lines)			Patch
M	sky/examples/widgets/tabs.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/tabs.dart	View	8 chunks	+48 lines, -17 lines	0 comments	Download
A +	sky/tests/examples/tabs.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A	sky/tests/examples/tabs-expected.txt	View	1 chunk	+128 lines, -0 lines	0 comments	Download

Total messages: 6 (3 generated)

hansmuller1

5 years, 5 months ago (2015-06-26 16:31:03 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as
a3dc3d45cc29ce7b1b529a1267d901201db55f07 (presubmit successful).