Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1213843002: Don't change the height of a layout object while not laying it out. (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, cbiesinger, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Don't change the height of a layout object while not laying it out. The old flexbox implementation did that. This still used to work halfheartedly by accident until the fix for bug 498770, though, because we used to mark out-of-flow positioned children in updateBlockChildDirtyBitsBeforeLayout(). But it never worked for anything other than direct children. Added one test for the recent regression (out-of-flow child) and one test that has probably never passed, until now (out-of-flow grandchild). We need to be inside layout() when setting the height of an object, or we won't be able to detect any changes and thus fail to relayout positioned descendants that may be affected. BUG=504239 R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198017

Patch Set 1 #

Patch Set 2 : Oh... right, the child. :-p #

Messages

Total messages: 6 (1 generated)
mstensho (USE GERRIT)
5 years, 6 months ago (2015-06-26 13:47:02 UTC) #1
mstensho (USE GERRIT)
5 years, 5 months ago (2015-06-29 18:49:24 UTC) #2
leviw_travelin_and_unemployed
Oof... I'm sorry you've now had to touch deprecated flexbox. LGTM, sir.
5 years, 5 months ago (2015-06-29 18:54:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213843002/20001
5 years, 5 months ago (2015-06-29 18:55:23 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 20:22:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198017

Powered by Google App Engine
This is Rietveld 408576698