DescriptionDon't change the height of a layout object while not laying it out.
The old flexbox implementation did that. This still used to work halfheartedly
by accident until the fix for bug 498770, though, because we used to mark
out-of-flow positioned children in updateBlockChildDirtyBitsBeforeLayout(). But
it never worked for anything other than direct children. Added one test for the
recent regression (out-of-flow child) and one test that has probably never
passed, until now (out-of-flow grandchild).
We need to be inside layout() when setting the height of an object, or we won't
be able to detect any changes and thus fail to relayout positioned descendants
that may be affected.
BUG=504239
R=leviw@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198017
Patch Set 1 #Patch Set 2 : Oh... right, the child. :-p #
Messages
Total messages: 6 (1 generated)
|