Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/compiler/lib/src/resolution/send_resolver.dart

Issue 1213833002: Use a FunctionSignature in CallStructure.signatureApplies (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/compiler/lib/src/compile_time_constants.dart ('K') | « pkg/compiler/lib/src/resolution/members.dart ('k') | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/send_resolver.dart
diff --git a/pkg/compiler/lib/src/resolution/send_resolver.dart b/pkg/compiler/lib/src/resolution/send_resolver.dart
index fa8cacc84a854af5b1aa865542c45346a041c58a..3dfd8640ee91c46eab67938ee6dfd79675b8843c 100644
--- a/pkg/compiler/lib/src/resolution/send_resolver.dart
+++ b/pkg/compiler/lib/src/resolution/send_resolver.dart
@@ -333,7 +333,9 @@ abstract class SendResolverMixin {
case AccessKind.SUPER_METHOD:
case AccessKind.TOPLEVEL_METHOD:
// TODO(johnniwinther): Should local function also be handled here?
- if (!selector.callStructure.signatureApplies(semantics.element)) {
+ FunctionElement function = semantics.element;
Anders Johnsen 2015/06/26 12:14:18 FunctionSignature signature = ....signature; ?
Johnni Winther 2015/06/26 12:50:23 Done.
+ if (!selector.callStructure.signatureApplies(
+ function.functionSignature)) {
return new IncompatibleInvokeStructure(semantics, selector);
}
break;
@@ -586,7 +588,7 @@ abstract class SendResolverMixin {
type,
effectiveTargetSemantics);
} else {
- if (!callStructure.signatureApplies(constructor)) {
+ if (!callStructure.signatureApplies(constructor.functionSignature)) {
return new ConstructorAccessSemantics(
ConstructorAccessKind.INCOMPATIBLE,
constructor,
« pkg/compiler/lib/src/compile_time_constants.dart ('K') | « pkg/compiler/lib/src/resolution/members.dart ('k') | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698