Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5270)

Unified Diff: chrome/common/extensions/api/media_galleries.idl

Issue 121383002: Media Galleries API Metadata: Add audio video metadata extractor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: refine metadata extraction logic Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/media_galleries.idl
diff --git a/chrome/common/extensions/api/media_galleries.idl b/chrome/common/extensions/api/media_galleries.idl
index 79c724e3fd9b51b4c19f9fefbdf128263a05ae51..a274c635d13e056d0c71ba2744f0ae58fbfa73ae 100644
--- a/chrome/common/extensions/api/media_galleries.idl
+++ b/chrome/common/extensions/api/media_galleries.idl
@@ -69,6 +69,24 @@ namespace mediaGalleries {
dictionary MediaMetadata {
// The browser sniffed mime type.
DOMString mimeType;
+
+ // Defined for images and video. In pixels.
+ long? height;
+ long? width;
+
+ // Defined for audio and video.
+ long? durationSeconds;
acolwell GONE FROM CHROMIUM 2014/01/03 19:14:04 nit: Consider using a double since time in HTMLMed
tommycli 2014/01/03 23:08:36 Done.
+
+ // FFmpeg-defined generic fields.
acolwell GONE FROM CHROMIUM 2014/01/03 19:14:04 I don't think it is wise to expose these fields in
Lei Zhang 2014/01/03 23:00:15 Chrome extensions and apps are not available on mo
tommycli 2014/01/03 23:08:36 Comment might be misleading. FFmpeg inspired the t
+ DOMString? album;
+ DOMString? artist;
+ DOMString? comment;
+ DOMString? copyright;
+ long? disc;
+ DOMString? genre;
+ DOMString? language;
+ DOMString? title;
+ long? track;
};
callback MediaMetadataCallback = void (MediaMetadata metadata);

Powered by Google App Engine
This is Rietveld 408576698