Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1213813003: [es6] Remove harmony-classes flag (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Remove harmony-classes flag Move class tests to es6 directory BUG=v8:3330 LOG=N R=adamk Committed: https://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf Cr-Commit-Position: refs/heads/master@{#29336}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove empty flags field from json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -2110 lines) Patch
M src/bootstrapper.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/parser.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/preparser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/scanner.h View 2 chunks +1 line, -8 lines 0 comments Download
M src/scanner.cc View 5 chunks +67 lines, -75 lines 0 comments Download
M test/cctest/compiler/test-run-jsops.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 39 chunks +22 lines, -71 lines 0 comments Download
M test/js-perf-test/JSTests.json View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/message/class-constructor-accessor.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/message/class-constructor-generator.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/message/rest-param-class-setter-strict.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/super-constructor.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/message/super-constructor-extra-statement.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/message/super-in-function.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/block-non-strict-errors.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/class-property-name-eval-arguments.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/classes.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/classes-experimental.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/classes-lazy-parsing.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/classes-maps.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/classes-subclass-arrays.js View 1 chunk +1 line, -2 lines 0 comments Download
A + test/mjsunit/es6/debug-step-into-class-extends.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/debug-step-into-constructor.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/regress/regress-3750.js View 1 chunk +1 line, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-455141.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/toMethod.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/array-concat.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/arrow-functions-lexical-arguments.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/class-computed-property-names-super.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/harmony/class-property-name-eval-arguments.js View 1 chunk +0 lines, -79 lines 0 comments Download
D test/mjsunit/harmony/classes.js View 1 chunk +0 lines, -948 lines 0 comments Download
D test/mjsunit/harmony/classes-experimental.js View 1 chunk +0 lines, -339 lines 0 comments Download
D test/mjsunit/harmony/classes-lazy-parsing.js View 1 chunk +0 lines, -34 lines 0 comments Download
D test/mjsunit/harmony/classes-maps.js View 1 chunk +0 lines, -68 lines 0 comments Download
D test/mjsunit/harmony/classes-subclass-arrays.js View 1 chunk +0 lines, -150 lines 0 comments Download
M test/mjsunit/harmony/computed-property-names-classes.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/computed-property-names-super.js View 1 chunk +1 line, -2 lines 0 comments Download
D test/mjsunit/harmony/debug-step-into-class-extends.js View 1 chunk +0 lines, -42 lines 0 comments Download
D test/mjsunit/harmony/debug-step-into-constructor.js View 1 chunk +0 lines, -113 lines 0 comments Download
M test/mjsunit/harmony/object-literals-super.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/harmony/regress/regress-3750.js View 1 chunk +0 lines, -8 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-455141.js View 1 chunk +0 lines, -15 lines 0 comments Download
M test/mjsunit/harmony/regress/regress-crbug-451770.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/rest-params.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/super.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/harmony/toMethod.js View 1 chunk +0 lines, -106 lines 0 comments Download
M test/mjsunit/strong/classes.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/strong/declaration-after-use.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/strong/super.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
arv (Not doing code reviews)
PTAL
5 years, 6 months ago (2015-06-26 20:33:35 UTC) #1
adamk
lgtm Exciting to see this carved in stone :) https://codereview.chromium.org/1213813003/diff/1/test/js-perf-test/JSTests.json File test/js-perf-test/JSTests.json (right): https://codereview.chromium.org/1213813003/diff/1/test/js-perf-test/JSTests.json#newcode31 test/js-perf-test/JSTests.json:31: ...
5 years, 6 months ago (2015-06-26 20:44:35 UTC) #2
arv (Not doing code reviews)
Remove empty flags field from json
5 years, 6 months ago (2015-06-26 20:45:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213813003/20001
5 years, 6 months ago (2015-06-26 20:46:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-26 21:16:49 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 21:17:06 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf
Cr-Commit-Position: refs/heads/master@{#29336}

Powered by Google App Engine
This is Rietveld 408576698