Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 1213813002: Work around flaky TextTrackList tests that will be stable with Oilpan (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
fs
CC:
blink-reviews, nessy, mlamouri+watch-blink_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, vcarbune.chromium
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Work around flaky TextTrackList tests that will be stable with Oilpan This test calls document.createElement('video').textTracks and has no reference to the video element. The TextTrackList doesn't keep its owner HTMLMediaElement alive, so if the owner is garbage collected, TextTrackList::executionContext() returns null. That in turn makes EventTarget::dispatchEvent() do nothing, and thus the assert_true(ran) fails because the event handler was in fact never run. The owner is a RawPtrWillBeMember<HTMLMediaElement>, so this problem will not occur with Oilpan, and does not seem worth addressing pre-Oilpan unless there's evidence of this happening in the wild. BUG=503852 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackList/onaddtrack.html View 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackList/onremovetrack.html View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213813002/1
5 years, 6 months ago (2015-06-26 10:47:01 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-26 11:44:09 UTC) #4
philipj_slow
PTAL at this non-fix :)
5 years, 6 months ago (2015-06-26 11:50:22 UTC) #6
fs
LGTM =(
5 years, 6 months ago (2015-06-26 11:54:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213813002/1
5 years, 6 months ago (2015-06-26 11:58:56 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 12:02:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197907

Powered by Google App Engine
This is Rietveld 408576698