Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: src/compiler/simplified-operator.cc

Issue 1213803008: [turbofan] Right hand side of shifts needs ToUint32. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/simplified-operator.h ('k') | src/compiler/typer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/simplified-operator.h" 5 #include "src/compiler/simplified-operator.h"
6 6
7 #include "src/base/lazy-instance.h" 7 #include "src/base/lazy-instance.h"
8 #include "src/compiler/opcodes.h" 8 #include "src/compiler/opcodes.h"
9 #include "src/compiler/operator.h" 9 #include "src/compiler/operator.h"
10 #include "src/types-inl.h" 10 #include "src/types-inl.h"
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 150
151 151
152 const ElementAccess& ElementAccessOf(const Operator* op) { 152 const ElementAccess& ElementAccessOf(const Operator* op) {
153 DCHECK_NOT_NULL(op); 153 DCHECK_NOT_NULL(op);
154 DCHECK(op->opcode() == IrOpcode::kLoadElement || 154 DCHECK(op->opcode() == IrOpcode::kLoadElement ||
155 op->opcode() == IrOpcode::kStoreElement); 155 op->opcode() == IrOpcode::kStoreElement);
156 return OpParameter<ElementAccess>(op); 156 return OpParameter<ElementAccess>(op);
157 } 157 }
158 158
159 159
160 #define PURE_OP_LIST(V) \ 160 #define PURE_OP_LIST(V) \
161 V(BooleanNot, Operator::kNoProperties, 1) \ 161 V(BooleanNot, Operator::kNoProperties, 1) \
162 V(BooleanToNumber, Operator::kNoProperties, 1) \ 162 V(BooleanToNumber, Operator::kNoProperties, 1) \
163 V(NumberEqual, Operator::kCommutative, 2) \ 163 V(NumberEqual, Operator::kCommutative, 2) \
164 V(NumberLessThan, Operator::kNoProperties, 2) \ 164 V(NumberLessThan, Operator::kNoProperties, 2) \
165 V(NumberLessThanOrEqual, Operator::kNoProperties, 2) \ 165 V(NumberLessThanOrEqual, Operator::kNoProperties, 2) \
166 V(NumberAdd, Operator::kCommutative, 2) \ 166 V(NumberAdd, Operator::kCommutative, 2) \
167 V(NumberSubtract, Operator::kNoProperties, 2) \ 167 V(NumberSubtract, Operator::kNoProperties, 2) \
168 V(NumberMultiply, Operator::kCommutative, 2) \ 168 V(NumberMultiply, Operator::kCommutative, 2) \
169 V(NumberDivide, Operator::kNoProperties, 2) \ 169 V(NumberDivide, Operator::kNoProperties, 2) \
170 V(NumberModulus, Operator::kNoProperties, 2) \ 170 V(NumberModulus, Operator::kNoProperties, 2) \
171 V(NumberToInt32, Operator::kNoProperties, 1) \ 171 V(NumberShiftLeft, Operator::kNoProperties, 2) \
172 V(NumberToUint32, Operator::kNoProperties, 1) \ 172 V(NumberShiftRight, Operator::kNoProperties, 2) \
173 V(PlainPrimitiveToNumber, Operator::kNoProperties, 1) \ 173 V(NumberShiftRightLogical, Operator::kNoProperties, 2) \
174 V(StringEqual, Operator::kCommutative, 2) \ 174 V(NumberToInt32, Operator::kNoProperties, 1) \
175 V(StringLessThan, Operator::kNoProperties, 2) \ 175 V(NumberToUint32, Operator::kNoProperties, 1) \
176 V(StringLessThanOrEqual, Operator::kNoProperties, 2) \ 176 V(PlainPrimitiveToNumber, Operator::kNoProperties, 1) \
177 V(ChangeTaggedToInt32, Operator::kNoProperties, 1) \ 177 V(StringEqual, Operator::kCommutative, 2) \
178 V(ChangeTaggedToUint32, Operator::kNoProperties, 1) \ 178 V(StringLessThan, Operator::kNoProperties, 2) \
179 V(ChangeTaggedToFloat64, Operator::kNoProperties, 1) \ 179 V(StringLessThanOrEqual, Operator::kNoProperties, 2) \
180 V(ChangeInt32ToTagged, Operator::kNoProperties, 1) \ 180 V(ChangeTaggedToInt32, Operator::kNoProperties, 1) \
181 V(ChangeUint32ToTagged, Operator::kNoProperties, 1) \ 181 V(ChangeTaggedToUint32, Operator::kNoProperties, 1) \
182 V(ChangeFloat64ToTagged, Operator::kNoProperties, 1) \ 182 V(ChangeTaggedToFloat64, Operator::kNoProperties, 1) \
183 V(ChangeBoolToBit, Operator::kNoProperties, 1) \ 183 V(ChangeInt32ToTagged, Operator::kNoProperties, 1) \
184 V(ChangeBitToBool, Operator::kNoProperties, 1) \ 184 V(ChangeUint32ToTagged, Operator::kNoProperties, 1) \
185 V(ObjectIsSmi, Operator::kNoProperties, 1) \ 185 V(ChangeFloat64ToTagged, Operator::kNoProperties, 1) \
186 V(ChangeBoolToBit, Operator::kNoProperties, 1) \
187 V(ChangeBitToBool, Operator::kNoProperties, 1) \
188 V(ObjectIsSmi, Operator::kNoProperties, 1) \
186 V(ObjectIsNonNegativeSmi, Operator::kNoProperties, 1) 189 V(ObjectIsNonNegativeSmi, Operator::kNoProperties, 1)
187 190
188 191
189 struct SimplifiedOperatorGlobalCache final { 192 struct SimplifiedOperatorGlobalCache final {
190 #define PURE(Name, properties, input_count) \ 193 #define PURE(Name, properties, input_count) \
191 struct Name##Operator final : public Operator { \ 194 struct Name##Operator final : public Operator { \
192 Name##Operator() \ 195 Name##Operator() \
193 : Operator(IrOpcode::k##Name, Operator::kPure | properties, #Name, \ 196 : Operator(IrOpcode::k##Name, Operator::kPure | properties, #Name, \
194 input_count, 0, 0, 1, 0, 0) {} \ 197 input_count, 0, 0, 1, 0, 0) {} \
195 }; \ 198 }; \
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 Operator1<Type>(IrOpcode::k##Name, Operator::kNoThrow | properties, \ 291 Operator1<Type>(IrOpcode::k##Name, Operator::kNoThrow | properties, \
289 #Name, value_input_count, 1, control_input_count, \ 292 #Name, value_input_count, 1, control_input_count, \
290 output_count, 1, 0, access); \ 293 output_count, 1, 0, access); \
291 } 294 }
292 ACCESS_OP_LIST(ACCESS) 295 ACCESS_OP_LIST(ACCESS)
293 #undef ACCESS 296 #undef ACCESS
294 297
295 } // namespace compiler 298 } // namespace compiler
296 } // namespace internal 299 } // namespace internal
297 } // namespace v8 300 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/simplified-operator.h ('k') | src/compiler/typer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698