Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 1213803002: Reland [android] Migrate more configs to gyp. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
Reviewers:
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland [android] Migrate more configs to gyp. This reverts commit e93e4dad632a019c6a863c7dd43491b607d6d096. BUG=chromium:502176 LOG=n NOTRY=true TBR=ulan@chromium.org, jochen@chromium.org Committed: https://crrev.com/7879474601991df9efddaccff821c4eda2b55f90 Cr-Commit-Position: refs/heads/master@{#29323}

Patch Set 1 #

Patch Set 2 : Fix - need to keep default for non-android arm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -11 lines) Patch
M Makefile.android View 1 chunk +7 lines, -11 lines 0 comments Download
M build/standalone.gypi View 1 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213803002/20001
5 years, 6 months ago (2015-06-26 12:02:24 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-26 12:04:03 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 12:04:18 UTC) #4
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7879474601991df9efddaccff821c4eda2b55f90
Cr-Commit-Position: refs/heads/master@{#29323}

Powered by Google App Engine
This is Rietveld 408576698