Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Unified Diff: net/spdy/spdy_session.cc

Issue 1213783005: Send HPKP violation reports when a pin check fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_client_socket_openssl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index 1eaa715b28a09b671cfcac2668e14cfe4c96ee90..ae2864e90c0dcd3cd5b7a4540c9a3d1d03f23916 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -598,10 +598,13 @@ bool SpdySession::CanPool(TransportSecurityState* transport_security_state,
return false;
std::string pinning_failure_log;
+ // TODO(estark): replace 0 below with the port of the connection
+ // (though it won't actually be used since reports aren't getting
+ // sent).
if (!transport_security_state->CheckPublicKeyPins(
- new_hostname,
- ssl_info.is_issued_by_known_root,
- ssl_info.public_key_hashes,
+ new_hostname, ssl_info.is_issued_by_known_root,
+ ssl_info.public_key_hashes, 0, ssl_info.unverified_cert.get(),
+ ssl_info.cert.get(), TransportSecurityState::DISABLE_PIN_REPORTS,
&pinning_failure_log)) {
return false;
}
« no previous file with comments | « net/socket/ssl_client_socket_openssl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698