Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 1213783002: Put getter functions on Script line-endings objects (Closed)

Created:
5 years, 6 months ago by Erik Corry Chromium.org
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Put getter functions on Script line-endings objects This is a step towards having Blink no longer look directly at the line endings array. That prevented https://codereview.chromium.org/1137683003/ from landing. Next step, after the roll, will be using these functions in Blink. R=jochen@chromium.org BUG= Committed: https://crrev.com/6ba8455e63712e9463685f63b22ffe64058adc9a Cr-Commit-Position: refs/heads/master@{#29330}

Patch Set 1 #

Patch Set 2 : Compile error on test #

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M src/messages.js View 2 chunks +12 lines, -1 line 0 comments Download
M test/cctest/cctest.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 1 2 1 chunk +15 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Erik Corry Chromium.org
5 years, 6 months ago (2015-06-26 09:58:46 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213783002/1
5 years, 6 months ago (2015-06-26 10:47:22 UTC) #3
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 6 months ago (2015-06-26 10:49:04 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213783002/20001
5 years, 6 months ago (2015-06-26 11:04:37 UTC) #7
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 6 months ago (2015-06-26 11:08:01 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213783002/40001
5 years, 6 months ago (2015-06-26 11:45:33 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-26 12:09:51 UTC) #13
Yang
On 2015/06/26 12:09:51, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 6 months ago (2015-06-26 14:20:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213783002/40001
5 years, 6 months ago (2015-06-26 14:57:29 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-26 14:58:57 UTC) #17
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 14:59:18 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6ba8455e63712e9463685f63b22ffe64058adc9a
Cr-Commit-Position: refs/heads/master@{#29330}

Powered by Google App Engine
This is Rietveld 408576698