Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1213743004: Revert of Fixing libpng transform use (Closed)

Created:
5 years, 5 months ago by jvanverth1
Modified:
5 years, 5 months ago
Reviewers:
msarett, scroggo, emmaleer
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fixing libpng transform use (patchset #5 id:80001 of https://codereview.chromium.org/1214203005/) Reason for revert: DEPS roll failing Original issue's description: > This change: > - supports kGray correctly > - avoid extra call to png_get_IHDR by storing the bit depth > - call transforms as needed > - checks for tRNS alpha value in RGB and GRAY color types > > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/9693037fd41b7ce545b44beaa3489dcfd915018c TBR=scroggo@google.com,msarett@google.com,emmaleer@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/6c90e09575c1a77aee060aa475fdb3d25a17d6a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -91 lines) Patch
M src/codec/SkCodec_libpng.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/codec/SkCodec_libpng.cpp View 14 chunks +96 lines, -86 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jvanverth1
Created Revert of Fixing libpng transform use
5 years, 5 months ago (2015-07-02 17:35:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213743004/1
5 years, 5 months ago (2015-07-02 17:35:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/6c90e09575c1a77aee060aa475fdb3d25a17d6a0
5 years, 5 months ago (2015-07-02 17:35:27 UTC) #3
scroggo
5 years, 5 months ago (2015-07-07 13:08:53 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1215853005/ by scroggo@google.com.

The reason for reverting is: This appears to have been reverted in order to fix
the DEPS roll in https://codereview.chromium.org/1214943004/

However, it only affects SkCodec, which is not used by Chromium. Relanding.

Powered by Google App Engine
This is Rietveld 408576698