Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1213713006: Update documentation of Uri.parse. (Closed)

Created:
5 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 5 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update documentation of Uri.parse. It currently says that parse tries to escape invalid characters. That's not true (at least not in most cases, though I think a few might still work). This just removes that part of the documentation. BUG= http://dartbug.com/23688 R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/8450179afefbfb8f88c01daa379163862c3edff5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M sdk/lib/core/uri.dart View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lasse Reichstein Nielsen
5 years, 5 months ago (2015-07-08 11:27:17 UTC) #2
Søren Gjesse
lgtm Should we make sure it is 100% strict - or will that be a ...
5 years, 5 months ago (2015-07-09 09:05:58 UTC) #3
Lasse Reichstein Nielsen
> Should we make sure it is 100% strict - or will that be a ...
5 years, 5 months ago (2015-07-09 09:19:16 UTC) #4
Lasse Reichstein Nielsen
5 years, 5 months ago (2015-07-09 10:24:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8450179afefbfb8f88c01daa379163862c3edff5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698