Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1213693006: [DevTools] Don't update Object Event Listeners sidebar when hidden (Closed)

Created:
5 years, 6 months ago by kozy
Modified:
5 years, 5 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Don't update Object Event Listeners sidebar when hidden BUG=503887 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197994

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger-step/debugger-step-out-document-write.html View 4 chunks +4 lines, -9 lines 0 comments Download
M LayoutTests/inspector/sources/debugger-step/debugger-step-out-document-write-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js View 1 2 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
kozy
ptal
5 years, 6 months ago (2015-06-26 15:42:30 UTC) #1
pfeldman
https://codereview.chromium.org/1213693006/diff/1/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js File Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js (right): https://codereview.chromium.org/1213693006/diff/1/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js#newcode27 Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js:27: if (this._lastRequestedContext) { if (!this.isShowing()) this._updateRequested = true; // ...
5 years, 5 months ago (2015-06-29 11:53:44 UTC) #2
kozy
https://codereview.chromium.org/1213693006/diff/1/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js File Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js (right): https://codereview.chromium.org/1213693006/diff/1/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js#newcode27 Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js:27: if (this._lastRequestedContext) { On 2015/06/29 11:53:44, pfeldman wrote: > ...
5 years, 5 months ago (2015-06-29 13:43:12 UTC) #3
pfeldman
lgtm
5 years, 5 months ago (2015-06-29 14:08:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213693006/20001
5 years, 5 months ago (2015-06-29 14:11:05 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 15:32:41 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197994

Powered by Google App Engine
This is Rietveld 408576698