Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1213623008: Back button should be able to close apps (Closed)

Created:
5 years, 5 months ago by jackson
Modified:
5 years, 5 months ago
Reviewers:
abarth, abarth-chromium
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : abarth cr feedback #

Patch Set 3 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -16 lines) Patch
M sky/sdk/example/stocks/lib/main.dart View 1 chunk +7 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/widget.dart View 1 2 chunks +9 lines, -1 line 0 comments Download
M sky/services/intents/BUILD.gn View 1 2 1 chunk +17 lines, -11 lines 0 comments Download
M sky/services/intents/intents.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M sky/services/intents/src/org/domokit/intents/ActivityManagerImpl.java View 3 chunks +15 lines, -0 lines 0 comments Download
M sky/shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sky/shell/android/org/domokit/sky/shell/SkyActivity.java View 2 chunks +3 lines, -0 lines 0 comments Download
M sky/shell/shell_view.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M sky/viewer/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jackson
5 years, 5 months ago (2015-07-07 00:05:20 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/1213623008/diff/1/sky/sdk/lib/widgets/widget.dart File sky/sdk/lib/widgets/widget.dart (right): https://codereview.chromium.org/1213623008/diff/1/sky/sdk/lib/widgets/widget.dart#newcode960 sky/sdk/lib/widgets/widget.dart:960: shell.requestService(null, activityManager); s/null/'mojo:sky_viewer'/
5 years, 5 months ago (2015-07-07 00:14:25 UTC) #3
abarth-chromium
To fix the test_sky errors, we'll need to add a dependency from //sky/viewer to //sky/services/intents:interfaces
5 years, 5 months ago (2015-07-07 00:15:27 UTC) #4
jackson
5 years, 5 months ago (2015-07-07 01:01:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
b3317f55e403242d7fcde6cb91b2a031bd931af0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698