Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: extensions/common/permissions/permission_message_util.h

Issue 1213623006: Extensions: Remove PermissionMessage (permission_message.h/cc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@kill_getmessages
Patch Set: fix app_shell build, rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/permission_message_util.h
diff --git a/extensions/common/permissions/permission_message_util.h b/extensions/common/permissions/permission_message_util.h
index 995d22663e8051c867b50233eceb996c03e20ded..fc006d7c85ccdc555b074f1f25d4bdf8d6df0590 100644
--- a/extensions/common/permissions/permission_message_util.h
+++ b/extensions/common/permissions/permission_message_util.h
@@ -13,7 +13,6 @@
namespace extensions {
class PermissionIDSet;
-class PermissionMessage;
class URLPatternSet;
}
@@ -23,20 +22,11 @@ enum PermissionMessageProperties { kReadOnly, kReadWrite };
// Get a list of hosts to display in a permission message from the given list of
// hosts from the manifest.
-// TODO(sashab): Merge this into AddHostPermissions() once CreateFromHostList()
-// is deprecated.
+// TODO(sashab): Merge this into AddHostPermissions().
std::vector<base::string16> GetHostListFromHosts(
const std::set<std::string>& hosts,
PermissionMessageProperties properties);
-// Creates the corresponding permission message for a list of hosts.
-// The messages change depending on how many hosts are present, and whether
-// |read_only| is true.
-// TODO(sashab): Deprecate this, prefer AddHostPermissions() instead.
-extensions::PermissionMessage CreateFromHostList(
- const std::set<std::string>& hosts,
- PermissionMessageProperties);
-
// Adds the appropriate permissions from given hosts to |permissions|.
void AddHostPermissions(extensions::PermissionIDSet* permissions,
const std::set<std::string>& hosts,
« no previous file with comments | « extensions/common/permissions/permission_message.cc ('k') | extensions/common/permissions/permission_message_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698