Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1213613013: Move parsing of "keyword only" SVG properties to CSSParserFastPaths (Closed)

Created:
5 years, 5 months ago by fs
Modified:
5 years, 5 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move parsing of "keyword only" SVG properties to CSSParserFastPaths Transfers responsibility for the following properties: alignment-baseline buffered-rendering clip-rule color-interpolation color-interpolation-filters color-rendering dominant-baseline fill-rule mask-type shape-rendering stroke-linecap stroke-linejoin text-anchor vector-effect writing-mode from CSSPropertyParser::parseSVGValue to CSSParserFastPaths. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199023

Patch Set 1 #

Patch Set 2 : Drop redundant comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -80 lines) Patch
M Source/core/css/parser/CSSParserFastPaths.cpp View 1 11 chunks +53 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 6 chunks +0 lines, -80 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
5 years, 5 months ago (2015-07-13 13:09:02 UTC) #2
Timothy Loh
On 2015/07/13 13:09:02, fs wrote: lgtm, but I'd leave out the comments repeating what values ...
5 years, 5 months ago (2015-07-16 00:44:56 UTC) #3
fs
On 2015/07/16 00:44:56, Timothy Loh wrote: > On 2015/07/13 13:09:02, fs wrote: > > lgtm, ...
5 years, 5 months ago (2015-07-16 08:36:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213613013/20001
5 years, 5 months ago (2015-07-16 09:31:28 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 09:55:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199023

Powered by Google App Engine
This is Rietveld 408576698