Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: tools/run_perf.py

Issue 1213613005: [test] Push binaries to separate folders on Android devices. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run_perf.py
diff --git a/tools/run_perf.py b/tools/run_perf.py
index 3f73ee6c250693bd48dd978e3b4bedd5eedeac1c..c04e4e77c3c2e70ecf26d46bb7658c396db25a8d 100755
--- a/tools/run_perf.py
+++ b/tools/run_perf.py
@@ -583,12 +583,22 @@ class AndroidPlatform(Platform): # pragma: no cover
bench_rel = "."
bench_abs = suite_dir
- self._PushFile(self.shell_dir, node.binary)
+ self._PushFile(self.shell_dir, node.binary, "bin")
# Push external startup data. Backwards compatible for revisions where
# these files didn't exist.
- self._PushFile(self.shell_dir, "natives_blob.bin", skip_if_missing=True)
- self._PushFile(self.shell_dir, "snapshot_blob.bin", skip_if_missing=True)
+ self._PushFile(
+ self.shell_dir,
+ "natives_blob.bin",
+ "bin",
+ skip_if_missing=True,
+ )
+ self._PushFile(
+ self.shell_dir,
+ "snapshot_blob.bin",
+ "bin",
+ skip_if_missing=True,
+ )
if isinstance(node, Runnable):
self._PushFile(bench_abs, node.main, bench_rel)
@@ -598,7 +608,8 @@ class AndroidPlatform(Platform): # pragma: no cover
def Run(self, runnable, count):
cache = cache_control.CacheControl(self.device)
cache.DropRamCaches()
- binary_on_device = AndroidPlatform.DEVICE_DIR + runnable.binary
+ binary_on_device = os.path.join(
+ AndroidPlatform.DEVICE_DIR, "bin", runnable.binary)
cmd = [binary_on_device] + runnable.GetCommandFlags(self.extra_flags)
# Relative path to benchmark directory.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698