Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1213603006: Initial fitness app (Closed)

Created:
5 years, 5 months ago by jackson
Modified:
5 years, 5 months ago
Reviewers:
Hixie, abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : abarth cr feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -16 lines) Patch
A + sky/sdk/example/fitness/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/example/fitness/apk/AndroidManifest.xml View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/sdk/example/fitness/lib/fitness_types.dart View 1 chunk +1 line, -1 line 0 comments Download
A sky/sdk/example/fitness/lib/home.dart View 1 1 chunk +206 lines, -0 lines 0 comments Download
A sky/sdk/example/fitness/lib/main.dart View 1 chunk +69 lines, -0 lines 0 comments Download
A + sky/sdk/example/fitness/lib/measurement.dart View 1 1 chunk +4 lines, -6 lines 0 comments Download
A sky/sdk/example/fitness/lib/settings.dart View 1 1 chunk +77 lines, -0 lines 0 comments Download
A + sky/sdk/example/fitness/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/sdk/example/fitness/sky.yaml View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Hixie
This should replace the stock app, IMHO. We're pivotting. If we have both, one will ...
5 years, 5 months ago (2015-07-07 23:52:22 UTC) #2
Hixie
This should replace the stock app, IMHO. We're pivotting. If we have both, one will ...
5 years, 5 months ago (2015-07-07 23:52:23 UTC) #4
jackson
I think we can treat stocks as a kitchen sink test app for widgets, and ...
5 years, 5 months ago (2015-07-08 00:01:20 UTC) #5
abarth-chromium
lgtm https://codereview.chromium.org/1213603006/diff/1/sky/sdk/example/fitness/lib/home.dart File sky/sdk/example/fitness/lib/home.dart (right): https://codereview.chromium.org/1213603006/diff/1/sky/sdk/example/fitness/lib/home.dart#newcode122 sky/sdk/example/fitness/lib/home.dart:122: ); Too much indent https://codereview.chromium.org/1213603006/diff/1/sky/sdk/example/fitness/lib/settings.dart File sky/sdk/example/fitness/lib/settings.dart (right): ...
5 years, 5 months ago (2015-07-08 00:05:31 UTC) #7
jackson
5 years, 5 months ago (2015-07-08 00:14:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
80afd13d49bf84f0be7d3d04805e4c5409dba6a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698