pkg/serialization/lib/serialization.dart - Issue 12136002: Some fixes to work better with the services framework

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/serialization/lib/serialization.dart

Issue 12136002: Some fixes to work better with the services framework (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Serialization updates to work more nicely with services framework Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/serialization/lib/serialization.dart

diff --git a/pkg/serialization/lib/serialization.dart b/pkg/serialization/lib/serialization.dart

index 3f2146d140cd58f33fea04af731f0bc4a041e8b0..8cdf09e83ce487f6ddd94ce1f2a73ed3bc692c21 100644

--- a/pkg/serialization/lib/serialization.dart

+++ b/pkg/serialization/lib/serialization.dart

@@ -351,7 +351,7 @@ class Serialization {

* class name as a key. In addition to the [externals] map provided here,

* values will be looked up in the [externalObjects] map.

- read(String input, [Map externals = const {}]) {

+ read(input, [Map externals = const {}]) {

justinfagnani 2013/02/09 21:21:56 now that the type annotation is removed, can you d

Alan Knight 2013/02/11 23:38:42 Done. Also fixed up the main doc comment some.

return newReader().read(input, externals);

}

« no previous file with comments | « no previous file | pkg/serialization/lib/src/basic_rule.dart » ('j') | pkg/serialization/lib/src/format.dart » ('J')